Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LZ4 transport compression by default #76326

Merged
merged 8 commits into from
Aug 17, 2021

Conversation

Tim-Brooks
Copy link
Contributor

This commit enables LZ4 transport compression by default at the
indexing_data level.

Relates to #73497.

This commit enables LZ4 transport compression by default at the
index_data level.
@Tim-Brooks Tim-Brooks added >enhancement :Distributed/Network Http and internode communication implementations team-discuss v8.0.0 labels Aug 10, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Aug 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@Tim-Brooks Tim-Brooks changed the title Enable LZ4 transport compression by default. Enable LZ4 transport compression by default Aug 11, 2021
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

`transport.compression_scheme` by default.

*Impact* +
This configuration means that transport compression will produce somewhat worse
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This configuration means that transport compression will produce somewhat worse
This configuration means that transport compression will produce somewhat lower

8.0, `transport.compress_scheme` defaults to `lz4`.

Prior to 8.0, the `cluster.remote.cluster_name.transport.compression_scheme` setting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we add <cluster_alias> into the setting names such that it is more clear that this does not concern a setting without the alias?

@Tim-Brooks
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/bwc

@Tim-Brooks Tim-Brooks merged commit 673e8e1 into elastic:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Network Http and internode communication implementations >enhancement Team:Distributed Meta label for distributed team v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants