Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQL: Fix join keys ordering in a sequence #76699

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented Aug 19, 2021

A sequence payload is constructed by providing a list of sequences and
a list of corresponding hits. When fetching the list of hits though, the list of
sequences can be iterated in reverse order to build the hit references;
meaning that the original list of sequences provided to the sequence
payload needs reversing too, as the join keys will be extracted from it.

Fixes #76209.

A sequence payload is constructed by providing one list of sequences and
one for the hits. When fetching the list of hits though, the list of
sequnces can be iterated in reverse order to build the hit references;
meaning that the original list of sequences provided to the sequence
payload needs reversing too.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit 79ae386 into elastic:master Aug 25, 2021
@bpintea bpintea deleted the fix/76209 branch August 25, 2021 08:22
bpintea added a commit to bpintea/elasticsearch that referenced this pull request Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and
one for the hits. When fetching the list of hits though, the list of
sequnces can be iterated in reverse order to build the hit references;
meaning that the original list of sequences provided to the sequence
payload needs reversing too.
bpintea added a commit to bpintea/elasticsearch that referenced this pull request Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and
one for the hits. When fetching the list of hits though, the list of
sequnces can be iterated in reverse order to build the hit references;
meaning that the original list of sequences provided to the sequence
payload needs reversing too.
bpintea added a commit to bpintea/elasticsearch that referenced this pull request Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and
one for the hits. When fetching the list of hits though, the list of
sequnces can be iterated in reverse order to build the hit references;
meaning that the original list of sequences provided to the sequence
payload needs reversing too.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.14
7.x
7.15

elasticsearchmachine pushed a commit that referenced this pull request Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and
one for the hits. When fetching the list of hits though, the list of
sequnces can be iterated in reverse order to build the hit references;
meaning that the original list of sequences provided to the sequence
payload needs reversing too.
elasticsearchmachine pushed a commit that referenced this pull request Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and
one for the hits. When fetching the list of hits though, the list of
sequnces can be iterated in reverse order to build the hit references;
meaning that the original list of sequences provided to the sequence
payload needs reversing too.
elasticsearchmachine pushed a commit that referenced this pull request Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and
one for the hits. When fetching the list of hits though, the list of
sequnces can be iterated in reverse order to build the hit references;
meaning that the original list of sequences provided to the sequence
payload needs reversing too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EQL sequence query returns inconsistent results
7 participants