Remove IncrementalClusterStateWriter & related code #79738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today there is no code that uses `IncrementalClusterStateWriter` (except its tests) and the only places that use `MetaStateService` to write state are tests that simulate upgrade from pre-7.6.0 versions too. This commit removes the dead `IncrementalClusterStateWriter` class and moves the write methods of `MetaStateService` into the test framework.
DaveCTurner
added
>non-issue
:Distributed Coordination/Cluster Coordination
elasticmachine
added
the
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
deleted the
2021-10-25-remove-IncrementalClusterStateWriter
branch
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 26, 2021
* upstream/master: (209 commits) Enforce license expiration (elastic#79671) TSDB: Automatically add timestamp mapper (elastic#79136) [DOCS] `_id` is required for bulk API's `update` action (elastic#79774) EQL: Add optional fields and limit joining keys on non-null values only (elastic#79677) [DOCS] Document range enrich policy (elastic#79607) [DOCS] Fix typos in 8.0 security migration (elastic#79802) Allow listing older repositories (elastic#78244) [ML] track inference model feature usage per node (elastic#79752) Remove IncrementalClusterStateWriter & related code (elastic#79738) Reuse previous indices lookup when possible (elastic#79004) Reduce merging in PersistedClusterStateService (elastic#79793) SQL: Adjust JDBC docs to use milliseconds for timeouts (elastic#79628) Remove endpoint for freezing indices (elastic#78918) [ML] add timeout parameter for DELETE trained_models API (elastic#79739) [ML] wait for .ml-state-write alias to be readable (elastic#79731) [Docs] Update edgengram-tokenizer.asciidoc (elastic#79577) [Test][Transform] fix UpdateTransformActionRequestTests failure (elastic#79787) Limit CS Update Task Description Size (elastic#79443) Apply the reader wrapper on can_match source (elastic#78988) [DOCS] Adds new transform limitation item and a note to the tutorial (elastic#79479) ... # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexMode.java # server/src/test/java/org/elasticsearch/index/TimeSeriesModeTests.java
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 28, 2021
Today there is no code that uses `IncrementalClusterStateWriter` (except its tests) and the only places that use `MetaStateService` to write state are tests that simulate upgrade from pre-7.6.0 versions too. This commit removes the dead `IncrementalClusterStateWriter` class and moves the write methods of `MetaStateService` into the test framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today there is no code that uses
IncrementalClusterStateWriter(exceptits tests) and the only places that use
MetaStateServiceto writestate are tests that simulate upgrade from pre-7.6.0 versions too. This
commit removes the dead
IncrementalClusterStateWriterclass and movesthe write methods of
MetaStateServiceinto the test framework.