-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about license to "Restore an Entire Cluster" docs #87485
Conversation
One customer reached out mentioning that it would be a good idea to remind users to re-upload the license after full cluster receovery from snapshot as one ca easily miss this when trying to figure out why some features aren't working after the restore.
@TheRiffRafi please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation. |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-security (Team:Security) |
Thanks @gwbrown for opening this issue. |
@bytebilly To be clear, I didn't open this issue; this is a community PR that I decided to shepherd. To add some context to this, the license is kept in the cluster state, which is overwritten when a snapshot is restored with The issue is that restoring the snapshotted cluster state may restore an old license (or at least so it appears from this contribution and reading the relevant code). I agree that it would be best to address this with a technical solution - it's weird that restoring a snapshot restores the license - but doing so will take time as we'll have to build new functionality to do that, so adding a note to the documentation here might not be a bad idea until we can do so. I do have some thoughts about the wording that I'll write up soon as a proper review. |
I can understand that it might be surprising in some cases, but if you are using snapshot + restore to migrate a cluster (e.g. to move to a different cloud provider) then having everything come along with you (including the license) is exactly the right behaviour. "weird" is going to be in the eye of the beholder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for kind of losing track of this one - it would definitely be good to have this note in the docs, so I've cleaned up the wording a little and moved it to the top of the list of features to start up again after restoring and this should be merged shortly. Thanks!!
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…108436) One user reached out mentioning that it would be a good idea to remind users to re-upload the license after full cluster recovery from snapshot as one can easily miss this when trying to figure out why some features aren't working after the restore. (cherry picked from commit 295fba3) Co-authored-by: Rafi Estrada <62263912+TheRiffRafi@users.noreply.github.com>
…108437) One user reached out mentioning that it would be a good idea to remind users to re-upload the license after full cluster recovery from snapshot as one can easily miss this when trying to figure out why some features aren't working after the restore. (cherry picked from commit 295fba3) Co-authored-by: Rafi Estrada <62263912+TheRiffRafi@users.noreply.github.com>
…108435) One user reached out mentioning that it would be a good idea to remind users to re-upload the license after full cluster recovery from snapshot as one can easily miss this when trying to figure out why some features aren't working after the restore. (cherry picked from commit 295fba3) Co-authored-by: Rafi Estrada <62263912+TheRiffRafi@users.noreply.github.com>
One user reached out mentioning that it would be a good idea to remind users to re-upload the license after full cluster recovery from snapshot as one can easily miss this when trying to figure out why some features aren't working after the restore.