Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of restored persistent settings #9051

Merged
merged 1 commit into from Jan 18, 2015

Conversation

@imotov
Copy link
Member

commented Dec 24, 2014

Closes #8830

@tlrx
tlrx reviewed Jan 6, 2015
View changes
src/test/java/org/elasticsearch/snapshots/DedicatedClusterSnapshotRestoreTests.java Outdated
.put("discovery.type", "zen")
.put("discovery.zen.ping_timeout", "200ms")
.put("discovery.initial_state_timeout", "500ms")
.put("gateway.type", "local")

This comment has been minimized.

Copy link
@tlrx

tlrx Jan 6, 2015

Member

Duplicate "gateway.type"

Note that gateway.local will be removed in #9128

This comment has been minimized.

Copy link
@imotov

imotov Jan 9, 2015

Author Member

Good point. Removing.

logger.warn("ignoring persistent setting [{}], [{}]", entry.getKey(), error);
}
} else {
logger.warn("ignoring persistent setting [{}], not dynamically updateable", entry.getKey());

This comment has been minimized.

Copy link
@tlrx

tlrx Jan 6, 2015

Member

When global cluster state is restored and has many settings, can't this line be too much verbose?

This comment has been minimized.

Copy link
@imotov

imotov Jan 9, 2015

Author Member

For the setting to be logged here it had to be 1) dynamic when snapshot was made, 2) converted into non-dynamic when restore is made and 3) configured as a persistent setting in snapshotted cluster. Since removal of a dynamic setting is pretty rare event in elasticsearch codebase, nothing should be logged here under normal circumstances.

This comment has been minimized.

Copy link
@tlrx

tlrx Jan 12, 2015

Member

Thanks for the explanation :)

@tlrx

This comment has been minimized.

Copy link
Member

commented Jan 6, 2015

LGTM left two minor comments

@imotov imotov force-pushed the imotov:issue-8830-validate-restored-settings branch to a4c92eb Jan 18, 2015
@imotov imotov merged commit a4c92eb into elastic:master Jan 18, 2015
1 check passed
1 check passed
CLA Commit author is a member of Elasticsearch
Details
@clintongormley clintongormley removed the review label Mar 19, 2015
@clintongormley clintongormley changed the title Snapshot/Restore: add validation of restored persistent settings Add validation of restored persistent settings Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.