Tests: Add upgrade step to static bwc tests #9207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, thank you for improving testing here. |
|
Should we backport to 1.x? It has this same infrastructure right? |
|
Yes, I have the backport ready, but I need to figure out a way to know what the "latest" is, so that the check before upgrading (to make sure we don't have a bogus index that doesn't need upgrading) works? It fails right now on 1.x. Or I could just remove this precheck and assume calling upgrade + check index is upgrade is enough? |
|
well the latest should be the current lucene version we are using? I think the check is good, in case background merging fails (we don't want to silently hide some merge exception) |
rjernst
added a commit
that referenced
this pull request
Jan 9, 2015
already on latest version. See #9207
|
Added to 1.x in 5caa42c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to happen just for 0.20 in 1.x, but now this will check upgrade works against all static indexes we have.