Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster set intersection #93284

Merged
merged 3 commits into from Jan 27, 2023
Merged

Faster set intersection #93284

merged 3 commits into from Jan 27, 2023

Conversation

joegallo
Copy link
Contributor

Replaces #93279

Unroll stream code, plain collections are faster for this.

Before:

Screen Shot 2023-01-26 at 5 36 15 PM

After:

Screen Shot 2023-01-26 at 5 38 30 PM

@joegallo joegallo added :Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.7.0 labels Jan 26, 2023
@joegallo joegallo requested a review from rjernst January 26, 2023 22:41
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@joegallo joegallo mentioned this pull request Jan 26, 2023
Closed
rjernst
rjernst approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you please also add an explicit empty test to SetsTests?

@joegallo joegallo merged commit 89475ee into elastic:main Jan 27, 2023
@joegallo joegallo deleted the faster-set-intersection branch January 27, 2023 16:48
jpountz pushed a commit to jpountz/elasticsearch that referenced this pull request Feb 2, 2023
@joegallo @jpountz
Faster set intersection (elastic#93284)
a94b508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joegallo @elasticsearchmachine @rjernst