Ensure that we don't pass negative timeInQueue to writeVLong
#9662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#writeVLong` can only serialize positive values, yet this BWC code in `PendingClusterTask` passes occational `-1` causing assertions to trip. It also yields completely wrong values ie. if `-1 is deserialized it yields `9223372036854775807`. This commit ensure that `timeInQueue` is positive ie. at least `0` Relates to elastic#8077
|
LGTM Maybe this can problem can occur on other places as well and a helper method on StreamOutput makes sense? |
I mean we had this problem all over the place but I don't see how a helper can improve it? Maybe we should upgrade the assertion to an exception? |
| out.writeVLong(timeInQueue); | ||
| } | ||
| out.writeVLong(Math.max(0, timeInQueue)); | ||
| } |
|
LGTM |
Having a small helper method on StreamOutput would prevent repeating this Math.max(...) logic many times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#writeVLongcan only serialize positive values, yet this BWC codein
PendingClusterTaskpasses occational-1causing assertions to trip.It also yields completely wrong values ie. if
-1is deserialized it yields9223372036854775807. This commit ensure thattimeInQueueis positive ie.at least
0Relates to #8077
Note this PR is against
1.x