ESQL: Load keyword fields missing doc_values
#98639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
needs:triage
csoulios
added
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
costin
reviewed
Aug 18, 2023
| // for the field type name to avoid adding a dependency to the module | ||
| if (fieldType instanceof KeywordFieldMapper.KeywordFieldType | ||
| || fieldType instanceof TextFieldMapper.TextFieldType | ||
| || "match_only_text".equals(fieldType.typeName())) { |
There was a problem hiding this comment.
Could be extracted into a constant.
There was a problem hiding this comment.
I'd left a comment on the other copy of this about how it'd be lovely if this could go backwards, with the mappers defining this behavior. But that's not worth the extra complexity now.
There was a problem hiding this comment.
I have thought about it too. Probably, the least invasive way to implement it in the field mappers is to add a new MappedFieldType.FielddataOperation.ESQL and use that in the MappedFieldType.fielddataBuilder() to define the behavior we need. I can give it a try in a following PR
nik9000
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for loading
keywordfields havingdoc_values: falsein their mapping.The code follows the same code path as when loading
textfields, loading field from the index (ifstoredistrue) or extracting from the_source.