-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly adjust docs about S3 incompatibilities #99624
Slightly adjust docs about S3 incompatibilities #99624
Conversation
It's often useful to quote these docs to users encountering problems with their not-quite-S3-compatible storage system. In practice we don't need to quote the bits in the middle but we do need the last sentence about working with the supplier to address incompatibilities. This commit reorders things so that the most commonly quoted sentences form a standalone paragraph.
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a minor suggestion you can take or leave as wanted. Thanks!
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
Thanks James, I took your shorter sentences and rejigged them a little more in d8957cd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great! Thanks @DaveCTurner!
It's often useful to quote these docs to users encountering problems with their not-quite-S3-compatible storage system. In practice we don't need to quote the bits in the middle but we do need the last sentence about working with the supplier to address incompatibilities. This commit reorders things so that the most commonly quoted sentences form a standalone paragraph.
It's often useful to quote these docs to users encountering problems with their not-quite-S3-compatible storage system. In practice we don't need to quote the bits in the middle but we do need the last sentence about working with the supplier to address incompatibilities. This commit reorders things so that the most commonly quoted sentences form a standalone paragraph.
It's often useful to quote these docs to users encountering problems with their not-quite-S3-compatible storage system. In practice we don't need to quote the bits in the middle but we do need the last sentence about working with the supplier to address incompatibilities. This commit reorders things so that the most commonly quoted sentences form a standalone paragraph.
It's often useful to quote these docs to users encountering problems with their not-quite-S3-compatible storage system. In practice we don't need to quote the bits in the middle but we do need the last sentence about working with the supplier to address incompatibilities. This commit reorders things so that the most commonly quoted sentences form a standalone paragraph.
It's often useful to quote these docs to users encountering problems
with their not-quite-S3-compatible storage system. In practice we don't
need to quote the bits in the middle but we do need the last sentence
about working with the supplier to address incompatibilities. This
commit reorders things so that the most commonly quoted sentences form a
standalone paragraph.