-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 8.12 custom documentation #470
Conversation
Should we PR |
@ferullo I'm not sure what did you do. Did you tested and fixed the custom documentation on I have the same question about |
The latter. This is what I've done in the past too. That's where the link ("... refer to the Endpoint event documentation.") on https://www.elastic.co/guide/en/security/master/siem-field-reference.html points. I'm not going to merge the endpoint PR used to test/generate these updates so this discrepancy won't create any merge problems.
@pzl can you answer that? |
The general case for branching is that everything merges into Making a release branch is usually just branching off from main during release time, and 2-3 commits are made to the release branch for the actual process of marking versions, then preparing a In this particular instance, we had a rather large breaking change, that was significant work to revert (across several PRs), so main and In the general case we do not merge anything from release branches back into main. There are version-specific commits we make during the branch cutting that should not pull into main. And certainly for
CI runs If you want this on the |
Package endpoint - 8.13.0 containing this change is available at https://epr.elastic.co/search?package=endpoint |
All changes are in
custom_documentation/
. These are the additions for 8.12.When I ran
make clean all
to re-render the markdown custom documentation I got a bunch of file changes inpackage/endpoint/data_stream/*fields/fields.yml
I can't explain. I did not commit them, since this PR is just mean to touchcustom_documentation/
. The changes seemed formatting related, I assume it's just a matter of my golang version/dependencies.