Feature/removing accept encoding header when using symfony http client #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# # Hier eventueel een uitleg over de wijziging ten op zichte van de # vorige versie max. 72 tekens per regel. # # Eventuele breaking changes hier vermelden en ook verwijzingen naar # tickets en andere resources. # Jira #WST-123 # Zie ook: http://podio.com/webstores/klant/stories/432
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
…using-symfony-http-client
|
I made some suggestions here on possible cleaner ways to fix this issue. The solution presented in this PR isn't bad, but what if it was made into a "whitelist" (or blacklist) of clients instead of being hard coded just to check for Symfony? Obviously that could get messy and turn into a maintenance headache but it may be better than the current state which appears to be causing confusion and support tickets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removing the Accept-Encoding: gzip header when using the Symfony HTTP client.
This is needed due to the Symfony behaviour reported here.
This is the same issue like here.