Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed query string params for App Search endpoints #5

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Nov 8, 2021

This PR fixes #4 moving the query parameters of App Search endpoints in the body request. This is a best practices reported in the documentation of App Search here.

src/AppSearch/Request/GetTopClicksAnalytics.php Outdated Show resolved Hide resolved
src/AppSearch/Request/GetTopClicksAnalytics.php Outdated Show resolved Hide resolved
src/AppSearch/Request/GetCountAnalytics.php Show resolved Hide resolved
src/AppSearch/Request/ListSynonymSets.php Outdated Show resolved Hide resolved
src/AppSearch/Request/ListSynonymSets.php Outdated Show resolved Hide resolved
@ezimuel
Copy link
Contributor Author

ezimuel commented Nov 9, 2021

@technige thanks for the review. I fixed the parameter name in the code generator.

@ezimuel ezimuel merged commit 15302d9 into elastic:7.13 Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants