Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button - Disabled variant is almost invisible in Dark theme #217

Closed
pickypg opened this issue Dec 19, 2017 · 1 comment
Closed

Button - Disabled variant is almost invisible in Dark theme #217

pickypg opened this issue Dec 19, 2017 · 1 comment

Comments

@pickypg
Copy link
Member

pickypg commented Dec 19, 2017

Browser: Chrome 63.0.3239.84
OS: Windows
Night Mode (yellowing effect): Enabled (I tried it without it being enabled and it does improve a little)

  • Button

Button

  • Button with Icon

ButtonWithIcon

  • ButtonEmpty

ButtonEmpty

  • Button Icon

ButtonIcon
@cchaos
Copy link
Contributor

cchaos commented Dec 22, 2017

Duplicate of #151?

@cjcenizal cjcenizal mentioned this issue Jan 23, 2018
Closed
snide added a commit to snide/eui that referenced this issue Mar 9, 2018
@snide
fix dark theme disable button contrast, fixes elastic#217
9b8e7b2
@snide snide mentioned this issue Mar 9, 2018
Merged
@snide snide closed this as completed in #487 Mar 9, 2018
snide added a commit that referenced this issue Mar 9, 2018
@snide
Misc. small fixes against outstanding issues (#487)
bfb011d 
* fix pagination arrows
* use portal on bottom bar, fixes #49
* fix dark theme disable button contrast, fixes #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cchaos @pickypg