Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiBetaBadge] Should also behave as a link #4190

Closed
miukimiu opened this issue Oct 28, 2020 · 1 comment
Closed

[EuiBetaBadge] Should also behave as a link #4190

miukimiu opened this issue Oct 28, 2020 · 1 comment
Assignees
@miukimiu

Comments

@miukimiu
Copy link
Contributor

miukimiu commented Oct 28, 2020 •
edited
Loading

The EuiBetaBadge doesn't allow links.

For instance, in cases, we have a disabled EuiCard with a beta badge the only interaction we can add is to trigger a tooltip. So if we want to add a link it's impossible.

This issue was raised on elastic/kibana#79627, where a workaround was introduced:

Screen Recording 2020-10-28 at 05 53 PM

Notice that there is another issue with this workaround:

  • On hover the EuiBetaBadge only changes the cursor. I think we can provide better hover states.
@miukimiu miukimiu mentioned this issue Dec 10, 2020
Closed
@miukimiu miukimiu self-assigned this Dec 10, 2020
@andreadelrio andreadelrio mentioned this issue May 18, 2021
Merged
6 tasks
@miukimiu
Copy link
Contributor Author

The PR #4798 fixed this issue. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miukimiu miukimiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miukimiu