-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SearchBar] Add custom_component filter #6226
[SearchBar] Add custom_component filter #6226
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_6226/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach looks good to me, have one suggestion for the example custom component
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
Preview documentation changes for this PR: https://eui.elastic.co/pr_6226/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6226/ |
Thanks for the first pass review @chandlerprall ! The PR is now ready for review, I added the docs and unit tests. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, go ahead and merge when CI passes
Preview documentation changes for this PR: https://eui.elastic.co/pr_6226/ |
Thanks for the review @chandlerprall 👍 |
This PR adds a new filter type to the Search bar:
custom_component
. This filter gives full control to the consumer to render the filter button + the panel.Fixes #6003
Example