Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wiki] Document puppeteer error on M1/M2 machines #6989

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

cee-chen
Copy link
Member

Summary

We had a few devs run into this issue last week in the EUI channel, and figured we should document fixes/workarounds more easily for folks since arm64 machines are starting to become more common.

QA

General checklist

N/A, internal/documentation only

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Jul 25, 2023
@cee-chen cee-chen requested a review from a team July 25, 2023 14:57
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6989/

Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @cee-chen. I have two small editorial suggestions. Feel free to use or discard.

wiki/contributing-to-eui/running-eui-locally.md Outdated Show resolved Hide resolved
wiki/contributing-to-eui/running-eui-locally.md Outdated Show resolved Hide resolved
Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
@cee-chen
Copy link
Member Author

👍 Thanks Trevor, added!

Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6989/

@cee-chen cee-chen merged commit 7495f15 into elastic:main Jul 25, 2023
1 check passed
@cee-chen cee-chen deleted the wiki/puppeteer branch July 25, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants