Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDescriptionList] Update display to grid for vertical column option with new props #7062

Merged
merged 56 commits into from
Aug 28, 2023

Commits on Aug 9, 2023

  1. add display grid

    kyrspl committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    58ab7cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1fd6bbd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    040cf19 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Configuration menu
    Copy the full SHA
    9d46054 View commit details
    Browse the repository at this point in the history
  2. add total max width

    kyrspl committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    28ef754 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Update src/components/description_list/description_list_types.ts

    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    kyrspl and cee-chen authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d64db92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c53c8a8 View commit details
    Browse the repository at this point in the history
  3. update test for column_gap

    kyrspl committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9bd8385 View commit details
    Browse the repository at this point in the history
  4. add changelog

    kyrspl committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    94c5f68 View commit details
    Browse the repository at this point in the history
  5. update documentation

    kyrspl committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    672f564 View commit details
    Browse the repository at this point in the history
  6. fix typo

    kyrspl committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    0ee59c5 View commit details
    Browse the repository at this point in the history
  7. fix typo in test

    kyrspl committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b25bc8f View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Configuration menu
    Copy the full SHA
    64e192c View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. update test desc

    kyrspl committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    c0c9e1f View commit details
    Browse the repository at this point in the history
  2. update keyboard snapshot

    kyrspl committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    3896845 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f160fc9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8f2c8ef View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Configuration menu
    Copy the full SHA
    fd1e4f7 View commit details
    Browse the repository at this point in the history
  2. fix typos

    kyrspl committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    79cc572 View commit details
    Browse the repository at this point in the history
  3. Update src-docs/src/views/description_list/description_list_example.js

    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    kyrspl and cee-chen authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8a59812 View commit details
    Browse the repository at this point in the history
  4. Update src-docs/src/views/description_list/description_list_example.js

    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    kyrspl and cee-chen authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    db9e57a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dde01e8 View commit details
    Browse the repository at this point in the history
  6. [PR feedback] Remove unnecessary mobile breakpoint CSS

    - it's not doing anything, as `display: grid` is not set and the child components already default to a responsive/stacked display
    cee-chen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f8faa78 View commit details
    Browse the repository at this point in the history
  7. [PR feedback] Remove row-gap CSS

    - this is already being handled by each individual child title/description component's `margin-top` CSS
    
    - adding it for column displays simply incorrectly doubles the spacing
    cee-chen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c11b79f View commit details
    Browse the repository at this point in the history
  8. [PR feedback] Remove columnGap from context

    - no child components are using it, so it isn't necessary to pass via context
    cee-chen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    2bd11ee View commit details
    Browse the repository at this point in the history
  9. prettier lint fix

    cee-chen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d35e84e View commit details
    Browse the repository at this point in the history
  10. Update downstream snapshots

    cee-chen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    1028d81 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Configuration menu
    Copy the full SHA
    2c7e070 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. refactor final

    kyrspl committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    507139a View commit details
    Browse the repository at this point in the history
  2. update context

    kyrspl committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    fc12fe6 View commit details
    Browse the repository at this point in the history
  3. update tests

    kyrspl committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4ec06df View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a38d4c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Configuration menu
    Copy the full SHA
    d3d8416 View commit details
    Browse the repository at this point in the history
  2. update tests

    kyrspl committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    56a791d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5311a63 View commit details
    Browse the repository at this point in the history
  4. Fix lint complaint

    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    521b4d7 View commit details
    Browse the repository at this point in the history
  5. CSS cleanup

    - fix missing `max-inline-size` - needed to use `:` and not a `=`
    
    - move max-width const outside of fn (micro-perf)
    
    - remove `column-display` const, just repeat the logic since it's one line and the important information is already a const
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a78ec7a View commit details
    Browse the repository at this point in the history
  6. [REFACTOR] Remove responsiveColumn CSS entirely, and instead use JS…

    … breakpoint logic to determine whether type is a row or a column
    
    - since that is basically the logic that's happening, and we're repeating CSS a lot by handling it there instead of in JS
    
    + opinionated - reorder imports by most to least generic
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3e1ad21 View commit details
    Browse the repository at this point in the history
  7. [REFACTOR] Remove responsiveColumns CSS & logic from child components

    - the logic should simply be inherited from the parent description list
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0f462d5 View commit details
    Browse the repository at this point in the history
  8. [refactor] update child types and tests

    - context should use types minus `responsiveColumn`
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7388ea2 View commit details
    Browse the repository at this point in the history
  9. misc newline nits

    - reorder imports - prefer ordering most generic to most specific, and using newlines to group
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0624a3c View commit details
    Browse the repository at this point in the history
  10. Fix row/column gap tests

    - props weren't doing anything without the correct type
    
    + fix variable to use camelCasing and not snake_casing
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    95641d0 View commit details
    Browse the repository at this point in the history
  11. [BREAKING CHANGE] Prop renames

    - todo: remaining changelog items
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    06ba99a View commit details
    Browse the repository at this point in the history
  12. Update datagrid usage

    - since `s` is the new row gutter size default, no need to specify it
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3e4d1f1 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    e4669e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1f74d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5710c75 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b6a0cb View commit details
    Browse the repository at this point in the history
  5. Update upcoming_changelogs/7062.md

    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    kyrspl and cee-chen authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3f49cad View commit details
    Browse the repository at this point in the history
  6. [docs] Fix prop names

    + clean up var names and callbacks
    cee-chen committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    eae95f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    024eb73 View commit details
    Browse the repository at this point in the history
  2. removed max-inline-size

    kyrspl committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    4808e81 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. changelog

    cee-chen authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    0f4bed3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    66354b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Configuration menu
    Copy the full SHA
    a1ffc4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7a5f7c View commit details
    Browse the repository at this point in the history