-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDescriptionList] Update display to grid for vertical column option with new props #7062
Commits on Aug 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 58ab7cc - Browse repository at this point
Copy the full SHA 58ab7ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fd6bbd - Browse repository at this point
Copy the full SHA 1fd6bbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 040cf19 - Browse repository at this point
Copy the full SHA 040cf19View commit details
Commits on Aug 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9d46054 - Browse repository at this point
Copy the full SHA 9d46054View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28ef754 - Browse repository at this point
Copy the full SHA 28ef754View commit details
Commits on Aug 11, 2023
-
Update src/components/description_list/description_list_types.ts
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d64db92 - Browse repository at this point
Copy the full SHA d64db92View commit details -
Configuration menu - View commit details
-
Copy full SHA for c53c8a8 - Browse repository at this point
Copy the full SHA c53c8a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bd8385 - Browse repository at this point
Copy the full SHA 9bd8385View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94c5f68 - Browse repository at this point
Copy the full SHA 94c5f68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 672f564 - Browse repository at this point
Copy the full SHA 672f564View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ee59c5 - Browse repository at this point
Copy the full SHA 0ee59c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b25bc8f - Browse repository at this point
Copy the full SHA b25bc8fView commit details
Commits on Aug 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 64e192c - Browse repository at this point
Copy the full SHA 64e192cView commit details
Commits on Aug 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c0c9e1f - Browse repository at this point
Copy the full SHA c0c9e1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3896845 - Browse repository at this point
Copy the full SHA 3896845View commit details -
Configuration menu - View commit details
-
Copy full SHA for f160fc9 - Browse repository at this point
Copy the full SHA f160fc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f2c8ef - Browse repository at this point
Copy the full SHA 8f2c8efView commit details
Commits on Aug 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fd1e4f7 - Browse repository at this point
Copy the full SHA fd1e4f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79cc572 - Browse repository at this point
Copy the full SHA 79cc572View commit details -
Update src-docs/src/views/description_list/description_list_example.js
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8a59812 - Browse repository at this point
Copy the full SHA 8a59812View commit details -
Update src-docs/src/views/description_list/description_list_example.js
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for db9e57a - Browse repository at this point
Copy the full SHA db9e57aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dde01e8 - Browse repository at this point
Copy the full SHA dde01e8View commit details -
[PR feedback] Remove unnecessary mobile breakpoint CSS
- it's not doing anything, as `display: grid` is not set and the child components already default to a responsive/stacked display
Configuration menu - View commit details
-
Copy full SHA for f8faa78 - Browse repository at this point
Copy the full SHA f8faa78View commit details -
[PR feedback] Remove
row-gap
CSS- this is already being handled by each individual child title/description component's `margin-top` CSS - adding it for column displays simply incorrectly doubles the spacing
Configuration menu - View commit details
-
Copy full SHA for c11b79f - Browse repository at this point
Copy the full SHA c11b79fView commit details -
[PR feedback] Remove
columnGap
from context- no child components are using it, so it isn't necessary to pass via context
Configuration menu - View commit details
-
Copy full SHA for 2bd11ee - Browse repository at this point
Copy the full SHA 2bd11eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d35e84e - Browse repository at this point
Copy the full SHA d35e84eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1028d81 - Browse repository at this point
Copy the full SHA 1028d81View commit details
Commits on Aug 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2c7e070 - Browse repository at this point
Copy the full SHA 2c7e070View commit details
Commits on Aug 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 507139a - Browse repository at this point
Copy the full SHA 507139aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc12fe6 - Browse repository at this point
Copy the full SHA fc12fe6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ec06df - Browse repository at this point
Copy the full SHA 4ec06dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a38d4c4 - Browse repository at this point
Copy the full SHA a38d4c4View commit details
Commits on Aug 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d3d8416 - Browse repository at this point
Copy the full SHA d3d8416View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56a791d - Browse repository at this point
Copy the full SHA 56a791dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5311a63 - Browse repository at this point
Copy the full SHA 5311a63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 521b4d7 - Browse repository at this point
Copy the full SHA 521b4d7View commit details -
- fix missing `max-inline-size` - needed to use `:` and not a `=` - move max-width const outside of fn (micro-perf) - remove `column-display` const, just repeat the logic since it's one line and the important information is already a const
Configuration menu - View commit details
-
Copy full SHA for a78ec7a - Browse repository at this point
Copy the full SHA a78ec7aView commit details -
[REFACTOR] Remove
responsiveColumn
CSS entirely, and instead use JS…… breakpoint logic to determine whether type is a row or a column - since that is basically the logic that's happening, and we're repeating CSS a lot by handling it there instead of in JS + opinionated - reorder imports by most to least generic
Configuration menu - View commit details
-
Copy full SHA for 3e1ad21 - Browse repository at this point
Copy the full SHA 3e1ad21View commit details -
[REFACTOR] Remove
responsiveColumns
CSS & logic from child components- the logic should simply be inherited from the parent description list
Configuration menu - View commit details
-
Copy full SHA for 0f462d5 - Browse repository at this point
Copy the full SHA 0f462d5View commit details -
[refactor] update child types and tests
- context should use types minus `responsiveColumn`
Configuration menu - View commit details
-
Copy full SHA for 7388ea2 - Browse repository at this point
Copy the full SHA 7388ea2View commit details -
- reorder imports - prefer ordering most generic to most specific, and using newlines to group
Configuration menu - View commit details
-
Copy full SHA for 0624a3c - Browse repository at this point
Copy the full SHA 0624a3cView commit details -
- props weren't doing anything without the correct type + fix variable to use camelCasing and not snake_casing
Configuration menu - View commit details
-
Copy full SHA for 95641d0 - Browse repository at this point
Copy the full SHA 95641d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06ba99a - Browse repository at this point
Copy the full SHA 06ba99aView commit details -
- since `s` is the new row gutter size default, no need to specify it
Configuration menu - View commit details
-
Copy full SHA for 3e4d1f1 - Browse repository at this point
Copy the full SHA 3e4d1f1View commit details
Commits on Aug 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e4669e5 - Browse repository at this point
Copy the full SHA e4669e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1f74d3 - Browse repository at this point
Copy the full SHA c1f74d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5710c75 - Browse repository at this point
Copy the full SHA 5710c75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b6a0cb - Browse repository at this point
Copy the full SHA 2b6a0cbView commit details -
Update upcoming_changelogs/7062.md
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3f49cad - Browse repository at this point
Copy the full SHA 3f49cadView commit details -
Configuration menu - View commit details
-
Copy full SHA for eae95f4 - Browse repository at this point
Copy the full SHA eae95f4View commit details
Commits on Aug 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 024eb73 - Browse repository at this point
Copy the full SHA 024eb73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4808e81 - Browse repository at this point
Copy the full SHA 4808e81View commit details
Commits on Aug 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0f4bed3 - Browse repository at this point
Copy the full SHA 0f4bed3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66354b7 - Browse repository at this point
Copy the full SHA 66354b7View commit details
Commits on Aug 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a1ffc4b - Browse repository at this point
Copy the full SHA a1ffc4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7a5f7c - Browse repository at this point
Copy the full SHA a7a5f7cView commit details