Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiComboBox] Fixes/reversions for Kibana FTR #7212

Merged
merged 4 commits into from
Sep 21, 2023
Merged

[EuiComboBox] Fixes/reversions for Kibana FTR #7212

merged 4 commits into from
Sep 21, 2023

Commits on Sep 21, 2023

  1. [setup] Add missing EuiTextTruncate classes

    @cee-chen
    cee-chen committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    82f0792 View commit details
    Browse the repository at this point in the history

  2. Fix Kibana FTR shenanigans 😭 

    - turns out removing title was a terrible mistake

- also selenium gets big mad about the overlaid full text, might as well mitigate it now
    @cee-chen
    cee-chen committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    78f904f View commit details
    Browse the repository at this point in the history

  3. [optional] Misc combobox cleanups 

    - [perf] remove truncation component completely if truncation isn't customized; fall back to CSS overflow instead

- fix buggy behavior where truncation would suddenly change if search value only consists of spaces (by trimming condition early)
    @cee-chen
    cee-chen committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    18d7946 View commit details
    Browse the repository at this point in the history

  4. changelog

    @cee-chen
    cee-chen committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b0a5698 View commit details
    Browse the repository at this point in the history