Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPageTemplate] Add new EuiPageTemplate.TopBar component for serverless navigation #7777

Closed
wants to merge 4 commits into from

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented May 21, 2024

Summary

closes #7765

top_bar

⚠️ TODOS:

  • Figure out child API for links? leave it flexible or try to make it opinionated? need to figure out what layouts are being used by Kibana solutions
  • Documentation

QA

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
      - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
      - [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • Updated the Figma library counterpart

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@cee-chen
Copy link
Member Author

@MichaelMarcialis @ryankeairns FYI that I'll probably ping you two about this work and try to schedule a call / chat about what kind of content should go into this top bar.

@cee-chen
Copy link
Member Author

cee-chen commented Jun 4, 2024

Quick TL;DR from our team sync with Marcialis today - 99.9% of design cases should have either left-side or right-side icons, so we could consider implementing an API similar to EuiHeader's sections or items props. Or we could always just leave a wildcard children to be rendered and let Kibana determine what to render in this top bar.

I might pull in @tsullivan at this point to discuss preferred API for content, since I believe he's implemented something similar in Kibana.

@cee-chen
Copy link
Member Author

Closing, Kibana has resolved this within their own repo.

@cee-chen cee-chen closed this Jun 11, 2024
@cee-chen cee-chen deleted the page-template/top-bar branch June 27, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiPageTemplate] Account for new serverless header style
3 participants