Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Add https to the security example for Kibana #26

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

Crazybus
Copy link
Contributor

Implements the config from #17 (comment)


secrets:
kubectl delete secret kibana-certificates || true
vault read -field=kibana.crt secret/devops-ci/helm-charts/kibana/security/certificates | base64 --decode > kibana.crt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly outside the scope of this PR, but we could remove the dependency on vault here by generating self-signed certs with openssl -- thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually true for all of the testing secrets except for the license. Although for users without a license hitting the trial API would also be acceptable for testing. I'm explicitly using a real license though because I know that some rules are more relaxed when using a trial (such as no node to node encryption being required).

I'm going to make an issue to make sure this gets done. End results is to make sure that all users and contributors can deploy the examples with minimal effort.

Copy link
Contributor

@jordansissel jordansissel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given I have only read, not tested, the security.yml. The Makefile refers to parts of Vault I don't have (and probably don't need) access to.

@Crazybus Crazybus merged commit aeac280 into master Jan 3, 2019
@Crazybus Crazybus deleted the respect_mah_securitay branch January 3, 2019 14:00
@Crazybus
Copy link
Contributor Author

Crazybus commented Jan 3, 2019

LGTM given I have only read, not tested, the security.yml. The Makefile refers to parts of Vault I don't have (and probably don't need) access to.

Thats what we have automated testing for :P You can see the results here: https://devops-ci.elastic.co/job/elastic+helm-charts+pull-request+integration-elasticsearch/12/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants