This repository has been archived by the owner on May 16, 2023. It is now read-only.
Only require setting masterService for custom master nodeGroups #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change means that the when the masterService is not set it will always point to $clusterName-master-headless. Now masterService only needs to be set when the nodeGroup name of the master is something different. For most users this just means one less value to set when sticking with the default naming for the master nodes group.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means that the when the masterService is not set it will
always point to $clusterName-master-headless. Now masterService only
needs to be set when the nodeGroup name of the master is something
different. For most users this just means one less value to set when
sticking with the default naming for the master nodes group.