-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
carbonblack_edr,checkpoint,cisco_umbrella,gcp,zeek: remove duplicate fields and fix types #4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
force-pushed
the
duplicated_fields_bis
branch
from
September 29, 2022 07:09
868f7c5
to
190e704
Compare
ShourieG
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…fields and fix types
efd6
force-pushed
the
duplicated_fields_bis
branch
from
September 29, 2022 07:36
190e704
to
e2f1af8
Compare
These were necessary to allow the v2 duplication checks, but break the tests.
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
firewall |
793.65 | 485.67 | -307.98 (-38.81%) | 💔 |
Package cisco_umbrella
👍(0) 💚(0) 💔(1)
Expand to view
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
log |
12195.12 | 8928.57 | -3266.55 (-26.79%) | 💔 |
Package zeek
👍(27) 💚(11) 💔(5)
Expand to view
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
connection |
22727.27 | 15873.02 | -6854.25 (-30.16%) | 💔 |
snmp |
25000 | 20000 | -5000 (-20%) | 💔 |
weird |
28571.43 | 22222.22 | -6349.21 (-22.22%) | 💔 |
x509 |
11627.91 | 8196.72 | -3431.19 (-29.51%) | 💔 |
dhcp |
21276.6 | 16393.44 | -4883.16 (-22.95%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
endorama
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GCP changes looks good to me!
This was referenced Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a second tranch of fixing duplicate fields in preparation for the ECS 8.5 update.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots