Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carbonblack_edr,checkpoint,cisco_umbrella,gcp,zeek: remove duplicate fields and fix types #4339

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 29, 2022

What does this PR do?

This is a second tranch of fixing duplicate fields in preparation for the ECS 8.5 update.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Sep 29, 2022
@efd6 efd6 marked this pull request as ready for review September 29, 2022 07:10
@efd6 efd6 requested review from a team as code owners September 29, 2022 07:10
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

These were necessary to allow the v2 duplication checks, but break the tests.
@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022

🚀 Benchmarks report

Package checkpoint 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
firewall 793.65 485.67 -307.98 (-38.81%) 💔

Package cisco_umbrella 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 12195.12 8928.57 -3266.55 (-26.79%) 💔

Package zeek 👍(27) 💚(11) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
connection 22727.27 15873.02 -6854.25 (-30.16%) 💔
snmp 25000 20000 -5000 (-20%) 💔
weird 28571.43 22222.22 -6349.21 (-22.22%) 💔
x509 11627.91 8196.72 -3431.19 (-29.51%) 💔
dhcp 21276.6 16393.44 -4883.16 (-22.95%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-29T08:04:53.215+0000

  • Duration: 72 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 328
Skipped 0
Total 328

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (51/51) 💚
Files 96.667% (87/90) 👎 -0.752
Classes 96.667% (87/90) 👎 -0.752
Methods 87.194% (783/898) 👎 -2.752
Lines 92.711% (11728/12650) 👍 1.348
Conditionals 100.0% (0/0) 💚

@endorama
Copy link
Member

@efd6 changes looks good to me. We are adding other data streams (i.e. #4325) how do we make sure we are not introducing changes not compatible with ECS@8.5.0?

Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCP changes looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants