Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Okta] update okta ECS version #1067

Merged
merged 6 commits into from
Jun 14, 2021
Merged

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Jun 1, 2021

What does this PR do?

Updates package ECS version to 1.10.
Sync module changes to packages if any.
Adds Preserve Raw event functionality if not already exists.
Adds pipeline tests if missing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

@elasticmachine
Copy link

elasticmachine commented Jun 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1067 updated

  • Start Time: 2021-06-14T07:18:51.183+0000

  • Duration: 15 min 4 sec

  • Commit: 19f9463

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

Trends 🧪

Image of Build Times

Image of Tests

@P1llus P1llus marked this pull request as ready for review June 7, 2021 15:13
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus
Copy link
Member Author

P1llus commented Jun 11, 2021

@marc-gr Any idea why the httpjson hbs file is used for both inputs? I saw it was included in the merge with master

@marc-gr
Copy link
Contributor

marc-gr commented Jun 11, 2021

@marc-gr Any idea why the httpjson hbs file is used for both inputs? I saw it was included in the merge with master

That is probably the merge being weird. The log input was just used for system tests and was removed here https://github.com/elastic/integrations/pull/1034/files

@P1llus
Copy link
Member Author

P1llus commented Jun 14, 2021

Could you give this another check @marc-gr ? It should now not have anything weird after the merge.

@P1llus P1llus requested a review from marc-gr June 14, 2021 07:19
@P1llus P1llus merged commit e3ef14e into elastic:master Jun 14, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* update okta ECS version

* linting, updating changelog and manifest

* update fields and linting

* update changelog and linting

* fixing weird merge results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants