add missing fields gcp audit logs #10886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
andrewkroh
added
the
Team:Security-Service Integrations
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
|
@efd6 @ShourieG would one of you be able to review the changes to the @kgeller we can't give it a ✅ since we're not codeowners but will you look over too for any feedback? EDIT: also the coverage failure can be ignored. @haetamoudi actually looking at some improvements in elastic/elastic-package#2063. |
efd6
reviewed
Sep 5, 2024
packages/gcp/data_stream/audit/_dev/test/pipeline/test-audit.log
Outdated
Show resolved
Hide resolved
packages/gcp/data_stream/audit/_dev/test/pipeline/test-audit.log
Outdated
Show resolved
Hide resolved
packages/gcp/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/gcp/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
kgeller
reviewed
Sep 5, 2024
packages/gcp/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/gcp/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
…efault.yml Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
…efault.yml Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
💚 Build Succeeded
History
|
|
|
@efd6 I addressed the changes from the comments, let me know if anything if missing to get approval |
kgeller
approved these changes
Sep 10, 2024
efd6
approved these changes
Sep 12, 2024
|
Package gcp - 2.38.0 containing this change is available at https://epr.elastic.co/search?package=gcp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add policy_violation_info, metadata and related fields to GCP audit logs.
Changes
policy_violation_info,metadataandrelatedfields to audit logs.emailfieldChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Follow the public documentation to ingest GCP Audit logs https://www.elastic.co/docs/current/integrations/gcp