-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IIS package #138
Conversation
Pinging @elastic/integrations (Team:Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
Also could you please post a screenshot with integration's configuration form in Kibana?
packages/iis/manifest.yml
Outdated
type: image/svg+xml | ||
format_version: 1.0.0 | ||
license: basic | ||
categories: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to add some categories here from https://github.com/elastic/package-registry/blob/e93e801a6dfbfa6f83c8b69f6e9405603151f937/util/package.go#L27-L51?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will come in a different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's fine! just out of curiosity is there any particular reason for this? is anything missing from the list of categories?
required: true | ||
show_user: true | ||
default: 10s | ||
title: IIS webserver metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
packages/iis/manifest.yml
Outdated
size: 1960x2820 | ||
type: image/png | ||
- src: /img/metricbeat-iis-application-pool-overview.png | ||
title: Metricbeat IIS Application Pool overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Metricbeat IIS Application Pool overview | |
title: Metricbeat IIS Application Pool Overview |
packages/iis/manifest.yml
Outdated
size: 3785x1986 | ||
type: image/png | ||
- src: /img/metricbeat-iis-webserver-overview.png | ||
title: Metricbeat IIS Webserver overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Metricbeat IIS Webserver overview | |
title: Metricbeat IIS Webserver Overview |
packages/iis/manifest.yml
Outdated
size: 3137x1366 | ||
type: image/png | ||
- src: /img/metricbeat-iis-webserver-process.png | ||
title: Metricbeat IIS Webserver process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Metricbeat IIS Webserver process | |
title: Metricbeat IIS Webserver Process |
packages/iis/manifest.yml
Outdated
size: 3108x1629 | ||
type: image/png | ||
- src: /img/metricbeat-iis-website-overview.png | ||
title: Metricbeat IIS Website overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Metricbeat IIS Website overview | |
title: Metricbeat IIS Website Overview |
packages/iis/manifest.yml
Outdated
type: image/svg+xml | ||
format_version: 1.0.0 | ||
license: basic | ||
categories: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's fine! just out of curiosity is there any particular reason for this? is anything missing from the list of categories?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* temp * temp * manifest * work on iis * remove local chnages * test * fix * update * update * work on review * update docs * review * update * camelcase
Import the IIS package
IIS error logs:
IIS access logs:
IIS application pool metrics:
IIS website metrics
IIS webserver metrics
Dashboards look good