Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crowdstrike] Add FDR data stream #1522

Merged
merged 2 commits into from
Aug 13, 2021
Merged

[crowdstrike] Add FDR data stream #1522

merged 2 commits into from
Aug 13, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Aug 12, 2021 •
edited
Loading

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

Related issues

Screenshots

image
fdr-overview

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Aug 12, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-13T10:51:48.305+0000

  • Duration: 15 min 30 sec

  • Commit: 4d80b6d

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

Trends 🧪

Image of Build Times

Image of Tests

@andrewkroh andrewkroh mentioned this pull request Aug 12, 2021
Closed
15 tasks
P1llus
P1llus reviewed Aug 13, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments

packages/crowdstrike/data_stream/fdr/agent/stream/stream.yml.hbs Show resolved Hide resolved
packages/crowdstrike/data_stream/fdr/agent/stream/aws-s3.yml.hbs Show resolved Hide resolved
packages/crowdstrike/data_stream/falcon/sample_event.json Outdated Show resolved Hide resolved
packages/crowdstrike/data_stream/fdr/_dev/test/pipeline/test-fdr.log-expected.json Show resolved Hide resolved
packages/crowdstrike/data_stream/fdr/_dev/test/pipeline/test-fdr.log-expected.json Show resolved Hide resolved
@marc-gr marc-gr merged commit 512db6f into elastic:master Aug 13, 2021
@marc-gr marc-gr deleted the crowdstrike-fdr branch August 13, 2021 14:07
@leehinman leehinman mentioned this pull request Aug 16, 2021
Closed
3 tasks
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@marc-gr
[crowdstrike] Add FDR data stream (elastic#1522)
6c9f180 
* Add FDR data stream

* Fixed overwritten event object and do suggested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
Integration:crowdstrike CrowdStrike
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crowdstrike Falcon Data Replicator
3 participants
@marc-gr @elasticmachine @P1llus