Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update configuration options definitions in the docs + add additional option for storage account #1546

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Aug 20, 2021

Add/update configuration options definitions in the docs + add additional option for storage account

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@narph narph self-assigned this Aug 20, 2021
@narph narph added the Team:Platforms Label for the Integrations - Platforms team label Aug 20, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Platforms)

@elasticmachine
Copy link

elasticmachine commented Aug 20, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-23T12:40:37.353+0000

  • Duration: 14 min 36 sec

  • Commit: 0478d04

Test stats 🧪

Test Results
Failed 0
Passed 131
Skipped 0
Total 131

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I bet this needs to be updated in other integrations too.

packages/azure_metrics/docs/monitor.md Show resolved Hide resolved
@narph narph requested a review from jsoriano August 23, 2021 12:42
@narph narph merged commit e9a8bf9 into elastic:master Aug 23, 2021
@narph narph deleted the azure-storage-type branch August 23, 2021 13:59
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
…onal option for storage account (elastic#1546)

* Add/update configuration options definitions in the docs

* changelog

* add images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants