Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Move GCP integration from experimental to GA #1568

Merged
merged 3 commits into from
Sep 15, 2021
Merged

[Enhancement] Move GCP integration from experimental to GA #1568

merged 3 commits into from
Sep 15, 2021

Conversation

suyograo
Copy link
Contributor

@suyograo suyograo commented Sep 1, 2021

What does this PR do?

Move GCP integration to GA from experimental. This will be used in the upcoming Dataflow integration project.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 1, 2021 •
edited
Loading

💚 CLA has been signed

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@suyograo
Copy link
Contributor Author

suyograo commented Sep 1, 2021

Not sure whats up with the CLA comment :)

@elasticmachine
Copy link

elasticmachine commented Sep 2, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-08T11:36:50.300+0000

  • Duration: 19 min 59 sec

  • Commit: ebdc3f0

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

Trends 🧪

Image of Build Times

Image of Tests

@suyograo
Copy link
Contributor Author

suyograo commented Sep 3, 2021

@andrewkroh can you take another look?

@andrewkroh
Copy link
Member

@suyograo I think the CLA is complaining because your commits don't contain an email. https://github.com/elastic/integrations/pull/1568.patch

From: Suyog Rao <>

@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Sep 3, 2021
@suyograo
Copy link
Contributor Author

suyograo commented Sep 3, 2021

@andrewkroh thanks didn't realize the email issue. I amended the commits and looks good. thats what happens when you don't code for a while ;)

@sayden
Copy link
Contributor

sayden commented Sep 5, 2021

@endorama FYI

@suyograo suyograo merged commit 25e98f9 into elastic:master Sep 15, 2021
@endorama endorama mentioned this pull request Sep 20, 2021
Merged
2 tasks
@endorama endorama mentioned this pull request Oct 15, 2021
Closed
23 tasks
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@suyograo
[Enhancement] Move GCP integration from experimental to GA (elastic#1568
1341a65 
)

* Move GCP integration from experimental to GA

* Use the PR for changelog

* release is required so add it back with ga value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
Integration:gcp Google Cloud Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suyograo @elasticmachine @andrewkroh @sayden