-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ModSecurity]Add modsecurity integration #1603
Conversation
💚 CLA has been signed |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
packages/modsecurity/data_stream/auditlog/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/modsecurity/data_stream/auditlog/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/modsecurity/data_stream/auditlog/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/modsecurity/data_stream/auditlog/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Hi @legoguy1000 I updated according to your review. Please also point me out if anything needs |
I don't see anything else that jumps out at me. Do the system tests pass when you run the locally? If so then I think you're probably good. |
Yes, tests are pass in my local box. |
jenkins run tests |
Are you able to sign the CLA in the comment above @sawwn23 ? |
packages/modsecurity/data_stream/auditlog/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/modsecurity/data_stream/auditlog/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Thanks for the contribution! :) I double checked the CLA, it does not seem to have been signed yet, did you add the same email address as you use for github? |
/test |
Sorry, I commit with a different email for first two. I signed both |
jenkins run tests |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sawwn23
Just two small nitpicks before its ready.
For some reason this PR also includes a package named "test", I think thats just a mistake right?
Once the ECS version number is fixed, and the test package removed, we can go ahead and merge!
packages/modsecurity/data_stream/auditlog/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
/test |
Seems like you also need to regenerate your test logs, so that they include the updated version @sawwn23, sorry for the inconvenience :( |
Never mind my pleasure. This is my first integration and has some mistakes. Also, Thanks for your guidance |
/test |
We always appreciate community PR's, so happy you wanted to add in a new integration :) @sawwn23: |
Thank you very much for your contributions @sawwn23, we really appreciate it! Please remember that we have a community program, so if you want to create contributions and receive swag for it, you can register your PR's there :) |
* initial modsecurity integration * update fixes * pipeline changes for date,audit data and url * update readme * bump to ecs 1.12.0 * generate test logs with ecs 1.12.0 * remove deault value for tz * format json Co-authored-by: Saw Winn Naung <sawwinnnaung@gmail.com>
What does this PR do?
ModSecurity audit log integration.
Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Author's Checklist
How to test this PR locally
Related issues
Screenshots