Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModSecurity]Add modsecurity integration #1603

Merged
merged 8 commits into from
Sep 17, 2021

Conversation

sawwn23
Copy link
Contributor

@sawwn23 sawwn23 commented Sep 8, 2021

What does this PR do?

ModSecurity audit log integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • Added data streams
  • Dashboards

How to test this PR locally

elastic-package stack up -d
eval "$(elastic-package stack shellinit)"
elastic-package test

Related issues

Screenshots

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 8, 2021

💚 CLA has been signed

@elasticmachine
Copy link

elasticmachine commented Sep 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-17T04:22:32.231+0000

  • Duration: 12 min 43 sec

  • Commit: 3962358

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

Trends 🧪

Image of Build Times

Image of Tests

@sawwn23
Copy link
Contributor Author

sawwn23 commented Sep 9, 2021

Hi @legoguy1000 I updated according to your review. Please also point me out if anything needs

@legoguy1000
Copy link
Contributor

Hi @legoguy1000 I updated according to your review. Please also point me out if anything needs

I don't see anything else that jumps out at me. Do the system tests pass when you run the locally? If so then I think you're probably good.

@sawwn23
Copy link
Contributor Author

sawwn23 commented Sep 10, 2021

Hi @legoguy1000 I updated according to your review. Please also point me out if anything needs

I don't see anything else that jumps out at me. Do the system tests pass when you run the locally? If so then I think you're probably good.

Yes, tests are pass in my local box.

@P1llus
Copy link
Member

P1llus commented Sep 14, 2021

jenkins run tests

@P1llus
Copy link
Member

P1llus commented Sep 14, 2021

Are you able to sign the CLA in the comment above @sawwn23 ?

@sawwn23
Copy link
Contributor Author

sawwn23 commented Sep 15, 2021

Are you able to sign the CLA in the comment above @sawwn23 ?

Hi @P1llus I signed the CLA. I changes all above and make some adjustments.

@P1llus
Copy link
Member

P1llus commented Sep 15, 2021

Thanks for the contribution! :) I double checked the CLA, it does not seem to have been signed yet, did you add the same email address as you use for github?

@P1llus
Copy link
Member

P1llus commented Sep 15, 2021

/test

@sawwn23
Copy link
Contributor Author

sawwn23 commented Sep 15, 2021

Thanks for the contribution! :) I double checked the CLA, it does not seem to have been signed yet, did you add the same email address as you use for github?

Sorry, I commit with a different email for first two. I signed both

@P1llus
Copy link
Member

P1llus commented Sep 15, 2021

jenkins run tests

@P1llus
Copy link
Member

P1llus commented Sep 16, 2021

/test

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sawwn23
Just two small nitpicks before its ready.
For some reason this PR also includes a package named "test", I think thats just a mistake right?
Once the ECS version number is fixed, and the test package removed, we can go ahead and merge!

@P1llus
Copy link
Member

P1llus commented Sep 16, 2021

/test

@P1llus
Copy link
Member

P1llus commented Sep 16, 2021

Seems like you also need to regenerate your test logs, so that they include the updated version @sawwn23, sorry for the inconvenience :(

@sawwn23
Copy link
Contributor Author

sawwn23 commented Sep 16, 2021

Seems like you also need to regenerate your test logs, so that they include the updated version @sawwn23, sorry for the inconvenience :(

Never mind my pleasure. This is my first integration and has some mistakes. Also, Thanks for your guidance

@P1llus
Copy link
Member

P1llus commented Sep 16, 2021

/test

@P1llus
Copy link
Member

P1llus commented Sep 16, 2021

We always appreciate community PR's, so happy you wanted to add in a new integration :)
I will let the tests run again, do a quick review just in case, and merge it if its working correctly.

@sawwn23:
And just so you know, a lot of us (including me) hang out in the community slack channel, so if you are thinking about creating integrations and such, I usually am in the #stack-beats channel :)

@P1llus P1llus merged commit 973a429 into elastic:master Sep 17, 2021
@P1llus
Copy link
Member

P1llus commented Sep 17, 2021

Thank you very much for your contributions @sawwn23, we really appreciate it!

Please remember that we have a community program, so if you want to create contributions and receive swag for it, you can register your PR's there :)

https://www.elastic.co/community/contributor

@sawwn23 sawwn23 deleted the modsecurity-integration branch September 17, 2021 08:42
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* initial modsecurity integration

* update fixes

* pipeline changes for date,audit data and url

* update readme

* bump to ecs 1.12.0

* generate test logs with ecs 1.12.0

* remove deault value for tz

* format json

Co-authored-by: Saw Winn Naung <sawwinnnaung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants