Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Apache integration GA #1607

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Make Apache integration GA #1607

merged 4 commits into from
Sep 13, 2021

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Sep 9, 2021

What does this PR do?

Release Apache integration as GA

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@sayden sayden added enhancement New feature or request Team:Integrations Label for the Integrations team labels Sep 9, 2021
@sayden sayden self-assigned this Sep 9, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

license: basic
description: This Elastic integration collects logs and metrics from Apache servers
type: integration
categories:
- web
release: experimental
release: ga
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be updated in the data stream manifests too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR "GA" for data streams means removing the "release" property at all (according to spec).

license: basic
description: This Elastic integration collects logs and metrics from Apache servers
type: integration
categories:
- web
release: experimental
release: ga
conditions:
kibana.version: "^7.14.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is it bound with a particular Kibana release or not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't. Why the version should be different if everything is the same? Maybe I'm missing something 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had an offline chat with Jaime, I agree we can take the risk here and leave the constraint as is (please ignore this comment).

@elasticmachine
Copy link

elasticmachine commented Sep 9, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-10T12:08:53.059+0000

  • Duration: 14 min 37 sec

  • Commit: f1a533c

Test stats 🧪

Test Results
Failed 0
Passed 43
Skipped 0
Total 43

Trends 🧪

Image of Build Times

Image of Tests

@mtojek mtojek self-requested a review September 10, 2021 07:37
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unadressed comments.

@mtojek
Copy link
Contributor

mtojek commented Sep 10, 2021

@sayden Please take a look at the CI report. If the package is "GA", you don't need the property "release".

@mtojek mtojek self-requested a review September 10, 2021 12:23
@sayden
Copy link
Contributor Author

sayden commented Sep 13, 2021

Ok so I removed the release property from data_streams :)

@sayden sayden merged commit 3f6fe1e into elastic:master Sep 13, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@sayden sayden deleted the make-ga/apache branch July 30, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants