-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Apache integration GA #1607
Conversation
Pinging @elastic/integrations (Team:Integrations) |
license: basic | ||
description: This Elastic integration collects logs and metrics from Apache servers | ||
type: integration | ||
categories: | ||
- web | ||
release: experimental | ||
release: ga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be updated in the data stream manifests too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR "GA" for data streams means removing the "release" property at all (according to spec).
license: basic | ||
description: This Elastic integration collects logs and metrics from Apache servers | ||
type: integration | ||
categories: | ||
- web | ||
release: experimental | ||
release: ga | ||
conditions: | ||
kibana.version: "^7.14.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is it bound with a particular Kibana release or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't. Why the version should be different if everything is the same? Maybe I'm missing something 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had an offline chat with Jaime, I agree we can take the risk here and leave the constraint as is (please ignore this comment).
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some unadressed comments.
@sayden Please take a look at the CI report. If the package is "GA", you don't need the property "release". |
Ok so I removed the |
What does this PR do?
Release Apache integration as GA
Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).