Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cisco Duo] Add cisco_duo package. #1629

Merged
merged 16 commits into from
Oct 11, 2021
Merged

[Cisco Duo] Add cisco_duo package. #1629

merged 16 commits into from
Oct 11, 2021

Conversation

vinit-chauhan
Copy link
Contributor

What does this PR do?

  • Generated the skeleton of Cisco Duo integration
  • Added 5 data streams ( Administrator Logs, Authentication Logs, Offline Enrollment Logs, Summary Logs, and Telephony Logs )
  • Added the ingest pipeline for All the data streams
  • Mapped fields to according to ecs schema and added Fields mata data in the appropriate yml file
  • Added dashboards and visualizations.
  • Added Pipeline tests for all the data streams
  • Added System test cases for all the data streams

#TODO:

  • Add data collection logic.
  • Resolve Issues with Dashboards.
  • Update system test cases according to data collection logic

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/cisco_duo directory.
  • Run the following command to run tests.

elastic-package test

Screenshots

image
image
image
image

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 9, 2021 •
edited
Loading

💚 CLA has been signed

@elasticmachine
Copy link

elasticmachine commented Sep 9, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-04T16:30:50.739+0000

  • Duration: 14 min 49 sec

  • Commit: 9841efe

Test stats 🧪

Test Results
Failed 0
Passed 54
Skipped 0
Total 54

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

vinitchauhan_crest and others added 8 commits September 9, 2021 22:54
@vinit-chauhan
Add cisco_duo package.
8613297
@vinit-chauhan
Merge branch 'package_cisco_duo' of https://github.com/vinit-elastic/…
43a2f10 
…integrations into package_cisco_duo
@vinit-chauhan
Merge branch 'package_cisco_duo' of https://github.com/vinit-elastic/…
6add3cd 
…integrations into package_cisco_duo
@vinit-chauhan
Merge branch 'package_cisco_duo' of https://github.com/vinit-elastic/…
e124577 
…integrations into package_cisco_duo
@vinit-chauhan
Merge branch 'package_cisco_duo' of https://github.com/vinit-elastic/…
6798b33 
…integrations into package_cisco_duo
@vinit-chauhan
Merge branch 'package_cisco_duo' of https://github.com/vinit-elastic/…
c9faac2 
…integrations into package_cisco_duo
@vinit-chauhan
Merge branch 'package_cisco_duo' of https://github.com/vinit-elastic/…
5aedf41 
…integrations into package_cisco_duo
@vinit-chauhan
Merge branch 'package_cisco_duo' of https://github.com/vinit-elastic/…
0b5e7c3 
…integrations into package_cisco_duo
@jamiehynds jamiehynds linked an issue Sep 15, 2021 that may be closed by this pull request
Cisco Duo #1082
Closed
15 tasks
@vinit-chauhan
Copy link
Contributor Author

ECS Mapping, Ingest pipeline, test-cases are ready for review

andrewkroh
andrewkroh approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor thing I noticed.

packages/cisco_duo/data_stream/admin/agent/stream/httpjson.yml.hbs Outdated Show resolved Hide resolved
@andrewkroh
Copy link
Member

run tests

@vinit-chauhan vinit-chauhan marked this pull request as ready for review September 29, 2021 13:07
@andrewkroh
Copy link
Member

run tests

@andrewkroh andrewkroh merged commit 3250d81 into elastic:master Oct 11, 2021
@vinit-chauhan vinit-chauhan deleted the package_cisco_duo branch October 12, 2021 09:57
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@vinit-chauhan
[Cisco Duo] Add cisco_duo package (elastic#1629)
816b955 
Added 5 data streams ( Administrator Logs, Authentication Logs, Offline Enrollment Logs, Summary Logs, and Telephony Logs). Added the ingest pipeline for all the data streams

Added dashboards and visualizations.

Added pipeline tests for all the data streams

Added system test cases for all the data streams

Co-authored-by: vinitchauhan_crest <vinit.chauhan@crestsatasys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehynds jamiehynds jamiehynds left review comments

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
New Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cisco Duo
4 participants
@vinit-chauhan @elasticmachine @andrewkroh @jamiehynds