Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network_traffic] Set title to Network Packet Capture #1764

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Sep 27, 2021

What does this PR do?

Set the title of the integration to "Network Packet Capture".

Also add config options for timeout and period to the flow data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Screenshots

Screen Shot 2021-09-27 at 10 23 32 AM

Screen Shot 2021-09-27 at 10 17 54 AM

Set the title of the integration to "Network Packet Capture".

Also add config options for `timeout` and `period` to the `flow` data stream.
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Sep 27, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-27T14:25:34.028+0000

  • Duration: 66 min 45 sec

  • Commit: ca54910

Test stats 🧪

Test Results
Failed 0
Passed 103
Skipped 0
Total 103

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link

@jamiehynds jamiehynds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @andrewkroh

@andrewkroh andrewkroh merged commit a7ab46e into elastic:master Sep 27, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Set the title of the integration to "Network Packet Capture".

Also add config options for `timeout` and `period` to the `flow` data stream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants