Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AbuseCH] Converting threat intel module to package #1866

Merged
merged 6 commits into from
Oct 13, 2021
Merged

[AbuseCH] Converting threat intel module to package #1866

merged 6 commits into from
Oct 13, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Oct 5, 2021 •
edited
Loading

What does this PR do?

Converts the AbuseCH filesets from filebeat modules to a new integration package

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus
Copy link
Member Author

P1llus commented Oct 5, 2021

Dashboards will be added in separate PR

@P1llus
Copy link
Member Author

P1llus commented Oct 5, 2021

Still missing some basic system tests, so the CI will fail for now.

@elasticmachine
Copy link

elasticmachine commented Oct 5, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-13T11:11:36.773+0000

  • Duration: 17 min 13 sec

  • Commit: 9f27000

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@P1llus P1llus requested a review from a team October 12, 2021 13:55
marc-gr
marc-gr approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the couple doubts

@P1llus P1llus merged commit d1b9e74 into elastic:master Oct 13, 2021
@joshdover joshdover mentioned this pull request Oct 14, 2021
Closed
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@P1llus
[AbuseCH] Converting threat intel module to package (elastic#1866)
dcb68c5 
* stashing

* initial commit of new package

* updating system tests

* Update changelog and change version

* new ecs version, moving to ga and new test files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees
No one assigned
Labels
7.16 candidate Integration:ti_abusech AbuseCH New Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@P1llus @elasticmachine @marc-gr @andrewkroh