Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows event log set IP to correct address #1920

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

r00tu53r
Copy link
Contributor

@r00tu53r r00tu53r commented Oct 14, 2021

What does this PR do?

Fix Windows event log set IP to correct address

  • Add templating around _ingest._value so that the literal
    value of "_ingest._value" is not set to related.ip
  • Update tests

Closes #1728

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

From package/windows -

elastic-package test pipeline

* Add templating around _ingest._value so that the literal
  value of "_ingest._value" is not set to related.ip
* Update tests

Closes elastic#1728
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@r00tu53r r00tu53r requested a review from P1llus October 14, 2021 06:47
@elasticmachine
Copy link

elasticmachine commented Oct 14, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-14T07:12:10.072+0000

  • Duration: 17 min 37 sec

  • Commit: ddf9267

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@r00tu53r r00tu53r merged commit d1a255e into elastic:master Oct 14, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Add templating around _ingest._value so that the literal
  value of "_ingest._value" is not set to related.ip
* Update tests

Closes elastic#1728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.15-candidate 7.16-candidate bug Something isn't working, use only for issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows integration for event logs error - sysmon
3 participants