Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache: changes for unified integration UI #2001

Merged
merged 3 commits into from
Nov 2, 2021
Merged

apache: changes for unified integration UI #2001

merged 3 commits into from
Nov 2, 2021

Conversation

endorama
Copy link
Member

What does this PR do?

Align package title and description for improved Unified Integration UI display.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • promote package to staging
  • promote package to production

How to test this PR locally

Related issues

Screenshots

@endorama endorama added the Team:Integrations Label for the Integrations team label Oct 21, 2021
@endorama endorama self-assigned this Oct 21, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

elasticmachine commented Oct 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-25T08:20:05.411+0000

  • Duration: 15 min 55 sec

  • Commit: cea81d5

Test stats 🧪

Test Results
Failed 0
Passed 43
Skipped 0
Total 43

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@endorama endorama changed the title activemq: changes for unified integration UI apache: changes for unified integration UI Oct 21, 2021
@@ -1,15 +1,15 @@
format_version: 1.0.0
name: apache
title: Apache
version: 1.1.1
title: Apache HTTP Server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to #1901 new tile should be Apache

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read this thread: #1901 (comment)

license: basic
description: This Elastic integration collects logs and metrics from Apache servers
description: Collect logs and metrics from the Apache servers with Elastic Agent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to #1901 description should be Collect logs and metrics from Apache servers with Elastic Agent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now, the the has been removed, so we were looking at the same file but the content changes. I updated the description.

@endorama
Copy link
Member Author

endorama commented Oct 21, 2021

@aspacca not sure if we are sourcing the information from the same file. I used the Elastic Agent tab in this spreadsheet

My bad, it seems like I was looking at an old version

@endorama endorama requested a review from aspacca October 28, 2021 12:34
@endorama endorama merged commit ec90854 into elastic:master Nov 2, 2021
@endorama endorama deleted the uniform-ui/apache branch November 2, 2021 09:52
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants