Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently map message field in windows integrations #2008

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

leehinman
Copy link
Contributor

What does this PR do?

  • update application, security, system data stream in systems
    integration
  • update powershell & powershell_operational in windows integration
  • update winlog integration

Use ECS mapping for message in all.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
    - [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

elastic-package test

Related issues

@leehinman leehinman added bug Something isn't working, use only for issues Team:Security-External Integrations labels Oct 22, 2021
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Oct 22, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-26T14:36:15.698+0000

  • Duration: 19 min 54 sec

  • Commit: 43bc1df

Test stats 🧪

Test Results
Failed 0
Passed 395
Skipped 0
Total 395

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P1llus
Copy link
Member

P1llus commented Oct 25, 2021

This fails most likely due to: elastic/elastic-package#551

- update application, security, system data stream in systems
  integration
- update powershell & powershell_operational in windows integration
- update winlog integration

Closes elastic#1736
Closes elastic#1737
@leehinman leehinman merged commit 5634dbf into elastic:master Oct 26, 2021
@leehinman leehinman deleted the windows_fields_sync branch October 26, 2021 14:57
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Consistently map message field in windows integrations

- update application, security, system data stream in systems
  integration
- update powershell & powershell_operational in windows integration
- update winlog integration

Closes elastic#1736
Closes elastic#1737

* Update changelogs with PR number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues
Projects
None yet
4 participants