Replace logfile input type with filestream type for container logs #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelKatsoulis
added
enhancement
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mtojek
reviewed
Nov 8, 2021
packages/kubernetes/changelog.yml
Outdated
| changes: | ||
| - description: Use filestream input for container_logs data stream | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/2041 |
| @@ -1,7 +1,7 @@ | |||
| title: "Kubernetes container logs" | |||
| type: logs | |||
| streams: | |||
| - input: logfile | |||
| - input: filestream | |||
There was a problem hiding this comment.
out of curiosity: will filestreams be available in 7.16 or just in 8.0?
There was a problem hiding this comment.
Filestream is available since v7.10 in Filebeat, and since 7.13 in Agent.
kvch
approved these changes
Nov 9, 2021
| symlinks: {{symlinks}} | ||
| prospector.scanner.symlinks: {{ symlinks }} | ||
| parsers: | ||
| - container: |
There was a problem hiding this comment.
Nit: stream is set to all by default. You can rewrite the config to be shorter like this:
parsers:
- container: ~
ChrsMark
approved these changes
Nov 9, 2021
|
Are these automatically released to install from Kibana when they're merged? or is there a separate release process to wait for? |
67 tasks
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
…lastic#2139) * Replace logfile input type with filestream type for container logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces
logfileinput type for collecting kubernetes container logs with Filestream type which brings many improvements.With filestream input CRI parsing is also supported by default with the use of container parser
Checklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).Related issues
filestreaminput for container logs #1526Screenshots
CRI logs parsed as plain text with
logfileinputCRI logs parsed correctly with
filestreaminput andcontainerparser