-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Package] httpjson custom input #2154
Conversation
Pinging @elastic/integrations (Team:Integrations) |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
@ruflin @narph @andrewkroh
This integration works very similarly to winlog and log packages, and is one of the many new input packages coming up. Started with this one as it is the most requested one at the moment. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
||
## Configuration | ||
|
||
The extensive documentation for the input is currently available [here](https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-httpjson.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move all the documentations over into integrations so we don't have to link to Filebeat here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaiyan-sheng Sure that's always a possibility as well, I was just unsure how large we would want the integration pages in fleet to be, as httpjson's documentation is large.
There is also lots of links to the httpjson documentation in the field descriptions of each option as well, but always up to discuss what is best :)
I personally think we should move it to live inside the integration as well.
Code LGTM.
|
@narph @kaiyan-sheng The place of the documentation is something we are still discussing internally, would you be able to see if there is anything else that should also change? |
For documentation it will most likely have to wait for: elastic/observability-docs#424 |
…sed on PR comments
Going ahead with the plans for these input packages, until the documentation has been moved to the new elastic-agent location, we will reference the filebeat documentation equivalent when needed. |
@andrewkroh could you please review/approve this PR, to ensure that we can publish the httpjson package (in line with the udp/tcp packages that shipped in 7.16)? There is ongoing discussion on docs, but I don't think linking to Filebeat input docs should be a blocker. We can update the links once agent input docs are available (elastic/observability-docs#424) |
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
* initial commit * update changelog and modify min version * add fixes for 7.16 versions * adding safer tags, ingest pipeline support and documentation fixes based on PR comments * Update packages/httpjson/_dev/build/docs/README.md Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> * Update packages/httpjson/_dev/build/docs/README.md Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> * Update docs Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
What does this PR do?
This PR adds a package to utilize the httpjson input with custom integration, similar to winlog and log packages.
Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).