Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QNAP NAS] Add QNAP NAS Logs package #2202

Merged
merged 11 commits into from
Dec 14, 2021
Merged

[QNAP NAS] Add QNAP NAS Logs package #2202

merged 11 commits into from
Dec 14, 2021

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Add QNAP NAS Logs package

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

cd packages/qnap_nas
elastic-package build && elastic-package stack down && elastic-package stack up --version 7.16.0-SNAPSHOT -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test -v

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Nov 21, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-08T14:49:50.599+0000

  • Duration: 16 min 14 sec

  • Commit: e49751f

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000 legoguy1000 marked this pull request as draft November 22, 2021 12:47
@legoguy1000 legoguy1000 marked this pull request as ready for review November 22, 2021 15:36
@P1llus
Copy link
Member

P1llus commented Nov 22, 2021

/test

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus P1llus requested a review from a team November 22, 2021 16:31
@P1llus P1llus merged commit 69fbcae into elastic:master Dec 14, 2021
@legoguy1000 legoguy1000 deleted the qnap-logs branch December 14, 2021 12:23
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@legoguy1000 @P1llus
[QNAP NAS] Add QNAP NAS Logs package (elastic#2202)
8fba5d1 
* Add QNAP NAS Package

* minor changes

* fix dataset name

* update pipeline

* update changelog

* Add dashboard and update pipeline

* Update readme and fix formatting

* Update manifest.yml

* Add ECS categorization

* fix readme

* update to 7.16.0

Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
Integration:qnap_nas QNAP NAS New Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legoguy1000 @elasticmachine @P1llus @andrewkroh