Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filebeat O365 Package #230

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Filebeat O365 Package #230

merged 2 commits into from
Aug 6, 2020

Conversation

andrewstucki
Copy link

What does this PR do?

This converts the Microsoft Office 365 filebeat module to a package including inputs for both the Azure API and log file inputs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Screenshots

Screen Shot 2020-08-05 at 11 41 21 AM

Screen Shot 2020-08-05 at 11 41 33 AM

Screen Shot 2020-08-05 at 11 44 11 AM

Screen Shot 2020-08-05 at 11 44 22 AM

Screen Shot 2020-08-05 at 11 52 55 AM

Screen Shot 2020-08-05 at 11 53 13 AM

Screen Shot 2020-08-05 at 12 01 18 PM

@andrewstucki andrewstucki added enhancement New feature or request Team:Integrations Label for the Integrations team Team:SIEM (Deprecated) labels Aug 5, 2020
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

Pinging @elastic/siem (Team:SIEM)

@andrewstucki andrewstucki changed the title O365 Filebeat O365 Package Aug 5, 2020
@elasticmachine
Copy link

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #230 opened]

  • Start Time: 2020-08-05T16:04:11.645+0000

  • Duration: 3 min 53 sec

@mtojek mtojek self-requested a review August 6, 2020 11:31
mtojek
mtojek approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure if you should present to the end user all configuration fields (show_user: true)

@andrewstucki andrewstucki merged commit 8d75247 into elastic:master Aug 6, 2020
@andrewstucki andrewstucki deleted the o365 branch August 6, 2020 13:37
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Filebeat O365 Package (elastic#230)
5bdb616 
* initial o365 migration

* Fix up package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:o365 Microsoft Office 365 New Integration Team:Integrations Label for the Integrations team Team:SIEM (Deprecated)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewstucki @elasticmachine @mtojek @andrewkroh