Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing labels.* and annotations.* fields to kubernetes package #2361

Merged
merged 5 commits into from
Dec 20, 2021
Merged

Add missing labels.* and annotations.* fields to kubernetes package #2361

merged 5 commits into from
Dec 20, 2021

Conversation

tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented Dec 20, 2021 •
edited
Loading

Signed-off-by: Tetiana Kravchenko tetiana.kravchenko@elastic.co

What does this PR do?

  • Add missing labels.* and annotations.* fields to kubernetes package resources: pod, container and service
  • update sample_event

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

@tetianakravchenko
add missing labels.* and annotations.* fields to pod,container and se…
c07b84c 
…rvice resources; update sample_events

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
add pr link; remove redundant node fields for service
eed45ea 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
run format and check
16c293d 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Dec 20, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-20T13:52:46.966+0000

  • Duration: 29 min 56 sec

  • Commit: dda4a2c

Test stats 🧪

Test Results
Failed 0
Passed 116
Skipped 0
Total 116

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

ChrsMark
ChrsMark reviewed Dec 20, 2021
View reviewed changes
packages/kubernetes/manifest.yml Outdated
@@ -1,7 +1,7 @@
format_version: 1.0.0
name: kubernetes
title: Kubernetes
version: 1.8.0
version: 1.8.1
Copy link
Member

@ChrsMark ChrsMark Dec 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say 1.9.0 and upgrade the stack version of the package to 8.1.0. We need to confirm though with ecosystem team that it's fine to remove the 7.16.0 constraint.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on this. We can leave the constraint as is for now, 7.16.0 + 8.0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the 1.9.0 but I don't think we should change the Kibana constraints. The older versions won't report those fields. This won't create any issue.If we remove the 7.16.0 then we won't be able to deliver bugfixes like #2288

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed version to 1.9.0 5ec5290

@tetianakravchenko
bump version of the package to 1.9.0
5ec5290 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
ChrsMark
ChrsMark approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for CI

@MichaelKatsoulis
Copy link
Contributor

I merged #2288 so you will have to resolve the version conflicts first

@tetianakravchenko tetianakravchenko merged commit f355109 into elastic:master Dec 20, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@tetianakravchenko
Add missing labels.* and annotations.* fields to kubernetes package (e…
8ee1f44 
…lastic#2361)

* add missing labels.* and annotations.* fields to pod,container and service resources; update sample_events

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add pr link; remove redundant node fields for service

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* run format and check

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* bump version of the package to 1.9.0

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing fields to the affected kubernetes package data_streams
4 participants
@tetianakravchenko @elasticmachine @MichaelKatsoulis @ChrsMark