Add memory.workingset.limit.pct field in container and pod data stream #2469
Conversation
MichaelKatsoulis
added
enhancement
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
| @@ -146,6 +146,11 @@ | |||
| metric_type: gauge | |||
| description: | | |||
| Working set memory usage | |||
| - name: limit.pct | |||
| type: scaled_float | |||
| format: percent | |||
There was a problem hiding this comment.
should here be added unit as well as metric_type? according to https://github.com/elastic/observability-dev/blob/main/docs/dc/integrations/development/generic_guidelines.md#document-all-fields
There was a problem hiding this comment.
You are right. Added in f0e4319
There was a problem hiding this comment.
@MichaelKatsoulis should also sample_event.json files get updated to include new fields?
There was a problem hiding this comment.
Yes It should! 2c918e3
| @@ -111,6 +111,11 @@ | |||
| metric_type: gauge | |||
| description: | | |||
| Total working set memory | |||
| - name: limit.pct | |||
| type: scaled_float | |||
| format: percent | |||
elastic#2469) * Add memory.workingset.limit.pct field in container and pod data stream
What does this PR do?
This PR adds
memory.working_set.limit.pctfield in kubernetes pod data stream andmemory.workingset.limit.pctin kubernetes container data stream following the addition of those fields in the k8s module metrcisets by #29547Checklist
changelog.ymlfile.How to test this PR locally
Bring up elastic stack version 8.1.0-SNAPSHOT and enable kubernetes integration.
The new fields with the correct types are added in the
metrics-kubernetes.podandmetrics-kubernetes.containerindex templates.Related issues
Screenshots