-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing metadata fields #2702
Add missing metadata fields #2702
Conversation
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blocking
@@ -1,7 +1,9 @@ | |||
apiVersion: batch/v1beta1 | |||
apiVersion: batch/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that you are editing this file could you fix its name? :)
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/kubernetes/changelog.yml
Outdated
- version: "1.17.2" | ||
changes: | ||
- description: Add missing metadata fields | ||
type: bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type: bug | |
type: bugfix |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
What does this PR do?
Adds missing to fields to fix #2693.
cc: @MichaelKatsoulis @tetianakravchenko @mtojek