Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP Endpoint] update README #2727

Merged
merged 3 commits into from
Feb 23, 2022
Merged

[HTTP Endpoint] update README #2727

merged 3 commits into from
Feb 23, 2022

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Feb 22, 2022 •
edited
Loading

What does this PR do?

Updating the readme with recommendations from PR.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a screenshot of the integration's readme from Kibana? I want to verify markdown tables work as expected.

@elasticmachine
Copy link

elasticmachine commented Feb 22, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-23T09:02:23.504+0000

  • Duration: 20 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@P1llus
Copy link
Member Author

P1llus commented Feb 23, 2022

@andrewkroh The table looks good, I added an extra spacing after the table just to make that look better as well:
image

andrewkroh
andrewkroh approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@P1llus P1llus merged commit a8b750b into elastic:main Feb 23, 2022
@andrewkroh andrewkroh mentioned this pull request Feb 28, 2022
Merged
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@P1llus
[HTTP Endpoint] update README (elastic#2727)
a862a83 
* update README

* Update changelog

* added spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P1llus @elasticmachine @andrewkroh