Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suricata] adding more network protocols #2772

Merged
merged 4 commits into from
Mar 7, 2022
Merged

[Suricata] adding more network protocols #2772

merged 4 commits into from
Mar 7, 2022

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Mar 7, 2022 •
edited
Loading

What does this PR do?

This adds a few more network.protocols that had some missing mapping for ECS.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@P1llus P1llus requested a review from a team as a code owner March 7, 2022 14:12
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Mar 7, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-07T16:10:50.863Z&rangeTo=2022-03-07T16:30:50.863Z&transactionName=BUILD Ingest-manager/integrations/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=ddd1cd2a6638783c37b91cc34c970bed&transactionId=fbba39c0af19efe7)

Expand to view the summary

Build stats

  • Start Time: 2022-03-07T16:20:50.863+0000

  • Duration: 12 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

andrewkroh
andrewkroh approved these changes Mar 7, 2022
View reviewed changes
packages/suricata/changelog.yml Outdated Show resolved Hide resolved
packages/suricata/changelog.yml Outdated Show resolved Hide resolved
P1llus and others added 2 commits March 7, 2022 17:20
@P1llus @andrewkroh
Update packages/suricata/changelog.yml
29bf3c3 
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@P1llus @andrewkroh
Update packages/suricata/changelog.yml
d85ecab 
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@andrewkroh andrewkroh added Integration:suricata Suricata enhancement New feature or request labels Mar 7, 2022
@P1llus P1llus merged commit 6756b38 into elastic:main Mar 7, 2022
@andrewkroh andrewkroh mentioned this pull request Mar 14, 2022
Merged
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@P1llus @andrewkroh
[Suricata] adding more network protocols (elastic#2772)
943eaa0 
* adding more network protocols

* reverting linting changes

* Update packages/suricata/changelog.yml

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>

* Update packages/suricata/changelog.yml

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:suricata Suricata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P1llus @elasticmachine @andrewkroh