Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cef] Append pipeline errors to error.message #2789

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Mar 8, 2022

What does this PR do?

If the decode_cef Beat processor has errors then those errors are
lost if there is a pipeline error.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related

@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cef Common Event Format (CEF) labels Mar 8, 2022
@andrewkroh andrewkroh requested a review from a team as a code owner March 8, 2022 17:39
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

If the decode_cef Beat processor has errors then those errors are
lost if there is a pipeline error.
@elasticmachine
Copy link

elasticmachine commented Mar 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-08T17:31:09.356Z&rangeTo=2022-03-08T17:51:09.356Z&transactionName=BUILD Ingest-manager/integrations/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=8a5a2e8ebc74b5bfc0bd9f33333aed9f&transactionId=0d6a258ae6457215)

Expand to view the summary

Build stats

  • Start Time: 2022-03-08T17:41:09.356+0000

  • Duration: 14 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 84
Skipped 0
Total 84

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh merged commit 2ac8564 into elastic:main Mar 9, 2022
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
If the decode_cef Beat processor has errors then those errors are
lost if there is a pipeline error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cef Common Event Format (CEF)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants