Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network traffic: add license note to doc page #2809

Merged
merged 2 commits into from
Mar 10, 2022
Merged

network traffic: add license note to doc page #2809

merged 2 commits into from
Mar 10, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 10, 2022 •
edited
Loading

What does this PR do?

This adds the required license notice to the public documentation for the network packet capture package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Confirm wording.

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations labels Mar 10, 2022
@efd6 efd6 requested a review from jamiehynds March 10, 2022 00:27
@efd6 efd6 requested a review from a team as a code owner March 10, 2022 00:27
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Mar 10, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-10T10:27:07.381Z&rangeTo=2022-03-10T10:47:07.381Z&transactionName=BUILD Ingest-manager/integrations/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=498cf397f1bd695d5a2220301945e53d&transactionId=5d0c013408b70c16)

Expand to view the summary

Build stats

  • Start Time: 2022-03-10T10:37:07.381+0000

  • Duration: 67 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 134
Skipped 0
Total 134

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 changed the title network traffic: add license not to doc page network traffic: add license note to doc page Mar 10, 2022
jamiehynds
jamiehynds reviewed Mar 10, 2022
View reviewed changes
packages/network_traffic/docs/README.md Outdated

## Licensing for Windows Systems

The Network Packet Capture Integration incorporates a bundled Npcap installation on Windows hosts. This installation is provided under license from Insecure.Com LLC ("The Nmap Project"). The license text is available [here](https://github.com/elastic/beats/blob/main/x-pack/packetbeat/LICENSE-Npcap.txt).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 Do you think we should make it clearer that's its an OEM license, just to make it clear that the user doesn't require an npcap license. e.g. "The installation is provided under an OEM license from Incsure.com......."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's some nice sugar. Sure. I'll make that change.

jamiehynds
jamiehynds approved these changes Mar 10, 2022
View reviewed changes
packages/network_traffic/_dev/build/docs/README.md
The Network Packet Capture Integration incorporates a bundled Npcap installation on Windows hosts. The installation is provided under an [OEM license](https://npcap.com/oem/redist.html) from Insecure.Com LLC ("The Nmap Project").
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 4211a95 into elastic:main Mar 10, 2022
@efd6 efd6 deleted the npclicense branch March 10, 2022 12:01
@andrewkroh andrewkroh mentioned this pull request Mar 14, 2022
Merged
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@efd6
network traffic: add license note to doc page (elastic#2809)
b15ac42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehynds jamiehynds jamiehynds approved these changes

@adriansr adriansr adriansr approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efd6 @elasticmachine @adriansr @jamiehynds