-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix k8s overview dashboard #2876
Conversation
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Did you check Kibana version in the dashboard/visualizations JSON files? EDIT: I suspect that you used/dumped using newer Kibana and now testing with 7.16.0. |
Yes this is intentional. The dashboards I build are leveraging 8.2 Kibana's features. Is this supported in testing or I have to wait? |
I guess that it means that the package won't be supported by older Kibanas and you need to update the Kibana version constraint. Dashboards are part of the package. |
Isn't https://github.com/elastic/integrations/pull/2876/files#diff-d20d8086b58468701d8a944fc3ead31ddcc098054affdcc335b69464b4c16c54R13 enough? Or I should completely remove the |
Yes, it's a breaking change for dashboards anyway. In this case you need to drop the 7.x part at all. |
@elastic/obs-cloudnative-monitoring are we ok with such change, removing the backwards compatibility with 7.x? |
@mtojek is there any reference about such changes' sanity? I'm wondering how safe it is to just remove the |
There are teams which already decided to support only the 8.x packages and, in case there is a necessity to release a bugfix, they push modified packages directly to Package Storage. Fortunately, these are really rare cases. The idea is to prevent overusing backporting and just design features to be backward compatible. There are open discussions around those issues and due to low priority, we don't look into them actively. I can give you references to those if you want to take a look and comment. |
I see, thanks for the extra info. |
As discussed internally with @elastic/obs-cloudnative-monitoring we move forward with releasing the package for version ^8.2 and if we need a bugfix for previous version of stack we will use direct branching and ad-hoc patch release of package. For example at the moment we are on |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@tetianakravchenko @MichaelKatsoulis this PR is ready for review :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
What does this PR do?
Fixes k8s dashboard as part of #2159. Porting PR for elastic/beats#30913 (+elastic/beats#30986):
Closes #2906 too.